From: David Miller <davem@davemloft.net>
To: phil@nwl.cc
Cc: florian@openwrt.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] korina: fix deadlock on RX FIFO overrun
Date: Wed, 02 Jun 2010 06:12:32 -0700 (PDT) [thread overview]
Message-ID: <20100602.061232.190373991.davem@davemloft.net> (raw)
In-Reply-To: <20100529232343.ABC1D4CD45@orbit.nwl.cc>
From: Phil Sutter <phil@nwl.cc>
Date: Sun, 30 May 2010 01:23:34 +0200
> By calling korina_restart(), the IRQ handler tries to disable the
> interrupt it's currently serving. This leads to a deadlock since
> disable_irq() waits for any running IRQ handlers to finish before
> returning. This patch addresses the issue by turning korina_restart()
> into a workqueue task, which is then scheduled when needed.
>
> Reproducing the deadlock is easily done using e.g. GNU netcat to send
> large amounts of UDP data to the host running this driver.
>
> Note that the same problem (and fix) applies to TX FIFO underruns, but
> apparently these are less easy to trigger.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Applied.
prev parent reply other threads:[~2010-06-02 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 23:23 [PATCH 1/3] korina: fix deadlock on RX FIFO overrun Phil Sutter
2010-06-02 13:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602.061232.190373991.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).