* [PATCH 2/3] korina: use netdev_alloc_skb_ip_align() here, too [not found] <1275175416-21267-1-git-send-email-phil@nwl.cc> @ 2010-05-29 23:23 ` Phil Sutter 2010-06-02 13:12 ` David Miller [not found] ` <1275175416-21267-2-git-send-email-phil@nwl.cc> 1 sibling, 1 reply; 4+ messages in thread From: Phil Sutter @ 2010-05-29 23:23 UTC (permalink / raw) To: David Miller; +Cc: Florian Fainelli, netdev This patch completes commit 89d71a66c40d629e3b1285def543ab1425558cd5 which missed this spot, as it seems. Signed-off-by: Phil Sutter <phil@nwl.cc> --- drivers/net/korina.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/korina.c b/drivers/net/korina.c index 13533f9..3e9b6b7 100644 --- a/drivers/net/korina.c +++ b/drivers/net/korina.c @@ -765,10 +765,9 @@ static int korina_alloc_ring(struct net_device *dev) /* Initialize the receive descriptors */ for (i = 0; i < KORINA_NUM_RDS; i++) { - skb = dev_alloc_skb(KORINA_RBSIZE + 2); + skb = netdev_alloc_skb_ip_align(dev, KORINA_RBSIZE); if (!skb) return -ENOMEM; - skb_reserve(skb, 2); lp->rx_skb[i] = skb; lp->rd_ring[i].control = DMA_DESC_IOD | DMA_COUNT(KORINA_RBSIZE); -- 1.6.4.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] korina: use netdev_alloc_skb_ip_align() here, too 2010-05-29 23:23 ` [PATCH 2/3] korina: use netdev_alloc_skb_ip_align() here, too Phil Sutter @ 2010-06-02 13:12 ` David Miller 0 siblings, 0 replies; 4+ messages in thread From: David Miller @ 2010-06-02 13:12 UTC (permalink / raw) To: phil; +Cc: florian, netdev From: Phil Sutter <phil@nwl.cc> Date: Sun, 30 May 2010 01:23:35 +0200 > This patch completes commit 89d71a66c40d629e3b1285def543ab1425558cd5 > which missed this spot, as it seems. > > Signed-off-by: Phil Sutter <phil@nwl.cc> Applied. ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1275175416-21267-2-git-send-email-phil@nwl.cc>]
* [PATCH 3/3] korina: count RX DMA OVR as rx_fifo_error [not found] ` <1275175416-21267-2-git-send-email-phil@nwl.cc> @ 2010-05-29 23:23 ` Phil Sutter 2010-06-02 13:13 ` David Miller 0 siblings, 1 reply; 4+ messages in thread From: Phil Sutter @ 2010-05-29 23:23 UTC (permalink / raw) To: David Miller; +Cc: Florian Fainelli, netdev This way, RX DMA overruns (actually being caused by overrun of the 512byte input FIFO) show up in ifconfig output. The rx_fifo_errors counter is unused otherwise. Signed-off-by: Phil Sutter <phil@nwl.cc> --- drivers/net/korina.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/korina.c b/drivers/net/korina.c index 3e9b6b7..c7a9bef 100644 --- a/drivers/net/korina.c +++ b/drivers/net/korina.c @@ -376,7 +376,7 @@ static int korina_rx(struct net_device *dev, int limit) if (devcs & ETH_RX_LE) dev->stats.rx_length_errors++; if (devcs & ETH_RX_OVR) - dev->stats.rx_over_errors++; + dev->stats.rx_fifo_errors++; if (devcs & ETH_RX_CV) dev->stats.rx_frame_errors++; if (devcs & ETH_RX_CES) -- 1.6.4.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] korina: count RX DMA OVR as rx_fifo_error 2010-05-29 23:23 ` [PATCH 3/3] korina: count RX DMA OVR as rx_fifo_error Phil Sutter @ 2010-06-02 13:13 ` David Miller 0 siblings, 0 replies; 4+ messages in thread From: David Miller @ 2010-06-02 13:13 UTC (permalink / raw) To: phil; +Cc: florian, netdev From: Phil Sutter <phil@nwl.cc> Date: Sun, 30 May 2010 01:23:36 +0200 > This way, RX DMA overruns (actually being caused by overrun of the > 512byte input FIFO) show up in ifconfig output. The rx_fifo_errors > counter is unused otherwise. > > Signed-off-by: Phil Sutter <phil@nwl.cc> Applied. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-02 13:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1275175416-21267-1-git-send-email-phil@nwl.cc>
2010-05-29 23:23 ` [PATCH 2/3] korina: use netdev_alloc_skb_ip_align() here, too Phil Sutter
2010-06-02 13:12 ` David Miller
[not found] ` <1275175416-21267-2-git-send-email-phil@nwl.cc>
2010-05-29 23:23 ` [PATCH 3/3] korina: count RX DMA OVR as rx_fifo_error Phil Sutter
2010-06-02 13:13 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).