From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: hadi@cyberus.ca, xiaosuo@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] act_nat: fix the wrong checksum when addr isn't in old_addr/mask
Date: Wed, 02 Jun 2010 06:52:16 -0700 (PDT) [thread overview]
Message-ID: <20100602.065216.141241865.davem@davemloft.net> (raw)
In-Reply-To: <20100530125811.GA8120@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 30 May 2010 22:58:11 +1000
> Yes the patch is correct.
>
> However, the fact that you need this patch means that your act_nat
> setup isn't perfect. Ideally all the unNATed packets should be
> filtered out before you hit act_nat.
Regardless of whether said configuration is optimal, we should
handle this case correctly.
So I have applied this patch.
prev parent reply other threads:[~2010-06-02 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 0:26 [PATCH v2] act_nat: fix the wrong checksum when addr isn't in old_addr/mask Changli Gao
2010-05-30 12:43 ` jamal
2010-05-30 12:58 ` Herbert Xu
2010-05-30 13:33 ` Changli Gao
2010-05-30 14:11 ` Changli Gao
2010-05-30 21:53 ` Herbert Xu
2010-06-02 13:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602.065216.141241865.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).