* [net-2.6 PATCH] e1000e: change logical negate to bitwise
@ 2010-06-02 23:43 Jeff Kirsher
2010-06-03 10:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2010-06-02 23:43 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Dan Carpenter, Bruce Allan, Jeff Kirsher
From: Dan Carpenter <error27@gmail.com>
The bitwise negate is intended here. With the logical negate the
condition is always false.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/e1000e/netdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 24507f3..57a7e41 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -2554,7 +2554,7 @@ static void e1000_init_manageability_pt(struct e1000_adapter *adapter)
mdef = er32(MDEF(i));
/* Ignore filters with anything other than IPMI ports */
- if (mdef & !(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664))
+ if (mdef & ~(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664))
continue;
/* Enable this decision filter in MANC2H */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-2.6 PATCH] e1000e: change logical negate to bitwise
2010-06-02 23:43 [net-2.6 PATCH] e1000e: change logical negate to bitwise Jeff Kirsher
@ 2010-06-03 10:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-06-03 10:30 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, error27, bruce.w.allan
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 02 Jun 2010 16:43:15 -0700
> From: Dan Carpenter <error27@gmail.com>
>
> The bitwise negate is intended here. With the logical negate the
> condition is always false.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-03 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-02 23:43 [net-2.6 PATCH] e1000e: change logical negate to bitwise Jeff Kirsher
2010-06-03 10:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).