* [Patch 2/2]r8169: remove redundant RTL_W32
@ 2010-06-03 11:27 Junchang Wang
2010-06-03 12:40 ` Ben Hutchings
2010-06-03 19:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Junchang Wang @ 2010-06-03 11:27 UTC (permalink / raw)
To: romieu; +Cc: davem, netdev
Writting "cmd" into "CounterAddrLow" twice is redundant.
Signed-off-by: Junchang Wang <junchangwang@gmail.com>
---
drivers/net/r8169.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 217e709..e0a77a0 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1207,7 +1207,6 @@ static void rtl8169_update_counters(struct net_device *dev)
RTL_W32(CounterAddrHigh, (u64)paddr >> 32);
cmd = (u64)paddr & DMA_BIT_MASK(32);
- RTL_W32(CounterAddrLow, cmd);
RTL_W32(CounterAddrLow, cmd | CounterDump);
while (wait--) {
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch 2/2]r8169: remove redundant RTL_W32
2010-06-03 11:27 [Patch 2/2]r8169: remove redundant RTL_W32 Junchang Wang
@ 2010-06-03 12:40 ` Ben Hutchings
2010-06-03 19:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2010-06-03 12:40 UTC (permalink / raw)
To: Junchang Wang; +Cc: romieu, davem, netdev
On Thu, 2010-06-03 at 19:27 +0800, Junchang Wang wrote:
> Writting "cmd" into "CounterAddrLow" twice is redundant.
[...]
I assume you've checked this against the datasheets for all 20 variants
of this hardware?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch 2/2]r8169: remove redundant RTL_W32
2010-06-03 11:27 [Patch 2/2]r8169: remove redundant RTL_W32 Junchang Wang
2010-06-03 12:40 ` Ben Hutchings
@ 2010-06-03 19:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-06-03 19:29 UTC (permalink / raw)
To: junchangwang; +Cc: romieu, netdev
From: Junchang Wang <junchangwang@gmail.com>
Date: Thu, 3 Jun 2010 19:27:23 +0800
> Writting "cmd" into "CounterAddrLow" twice is redundant.
>
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
I definitely think this is being done on purpose.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-03 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03 11:27 [Patch 2/2]r8169: remove redundant RTL_W32 Junchang Wang
2010-06-03 12:40 ` Ben Hutchings
2010-06-03 19:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).