From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, joe@perches.com,
emil.s.tantilov@intel.com
Subject: Re: [net-next-2.6 PATCH] ixgbe: Use netdev_<level>, dev_<level>, pr_<level>
Date: Thu, 03 Jun 2010 20:04:43 -0700 (PDT) [thread overview]
Message-ID: <20100603.200443.104041687.davem@davemloft.net> (raw)
In-Reply-To: <20100604025225.16120.30293.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 03 Jun 2010 19:53:41 -0700
> From: Emil Tantilov <emil.s.tantilov@intel.com>
>
> This patch is alternative to a previous patch submitted by Joe Perches.
>
> Create common macros e_<level> and e_dev_<level> that use netdev_<level> and
> dev_<level> similar to e1000e.
> Redefined pr_fmt for driver messages.
> Use %pM to display MAC address.
> Aligned text to better match the new format.
>
> CC: Joe Perches <joe@perches.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, but:
> /**
> - * ixgbe_get_hw_dev_name - return device name string
> + * ixgbe_get_hw_dev return device
> * used by hardware layer to print debugging information
> **/
This line had trailing whitespace, which GIT warns about and I
had to remove.
next prev parent reply other threads:[~2010-06-04 3:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 2:53 [net-next-2.6 PATCH] ixgbe: Use netdev_<level>, dev_<level>, pr_<level> Jeff Kirsher
2010-06-04 3:04 ` David Miller [this message]
2010-06-04 3:15 ` Jeff Kirsher
2010-06-04 3:20 ` Joe Perches
2010-06-04 23:44 ` Tantilov, Emil S
2010-06-05 5:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603.200443.104041687.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox