From: Francois Romieu <romieu@fr.zoreil.com>
To: Junchang Wang <junchangwang@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [Patch 1/2]r8169: remove rtl_rw_cpluscmd
Date: Thu, 3 Jun 2010 23:42:57 +0200 [thread overview]
Message-ID: <20100603214257.GA3327@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20100603112428.GC24909@host-a-55.ustcsz.edu.cn>
Junchang Wang <junchangwang@gmail.com> :
> Some clean up work. Please correct me if any of this is wrong.
>
> Writting "cmd" back without modification is redundant.
> Secondly, because rtl_rw_cpluscmd is just encapsulation of
> RTL_R16, remove rtl_rw_cpluscmd.
I'll figure that there may be some value in the patch if you
test the change on revision X, Y and Z.
Some cosmetic isolated in a sequence of changes can be fine too.
Otherwise I consider such cleanups as a (useless and) conceivably
harmful distraction.
--
Ueimor
next prev parent reply other threads:[~2010-06-03 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 11:24 [Patch 1/2]r8169: remove rtl_rw_cpluscmd Junchang Wang
2010-06-03 21:42 ` Francois Romieu [this message]
2010-06-04 1:37 ` Junchang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603214257.GA3327@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=davem@davemloft.net \
--cc=junchangwang@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox