From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/2] net: Enable 64-bit net device statistics on 32-bit architectures Date: Fri, 4 Jun 2010 10:28:52 -0700 Message-ID: <20100604102852.08ce3cd1@nehalam> References: <1275576667.2106.11.camel@achroite.uk.solarflarecom.com> <1275586744.2106.22.camel@achroite.uk.solarflarecom.com> <20100603114738.41256434@nehalam> <1275592298.2106.36.camel@achroite.uk.solarflarecom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Miller , Arnd Bergmann , netdev@vger.kernel.org, linux-net-drivers@solarflare.com To: Ben Hutchings Return-path: Received: from mail.vyatta.com ([76.74.103.46]:47749 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970Ab0FDR27 (ORCPT ); Fri, 4 Jun 2010 13:28:59 -0400 In-Reply-To: <1275592298.2106.36.camel@achroite.uk.solarflarecom.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 03 Jun 2010 20:11:38 +0100 Ben Hutchings wrote: > static inline u64 rtnl_link_stats64_read(const u64 *field) > { > return ACCESS_ONCE(*field); > } > static inline u32 rtnl_link_stats64_read32(const u64 *field) > { > return ACCESS_ONCE(*field); > } Do we really care if compiler reorders access. I think not. There was no order guarantee in the past. --