* [PATCH net-next-2.6] [PPPOE] fix return value of __pppoe_xmit() method.
@ 2010-06-03 15:02 Rami Rosen
2010-06-05 9:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2010-06-03 15:02 UTC (permalink / raw)
To: davem, netdev
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
Hi,
__pppoe_xmit() in drivers/net/pppoe always returns 1.
When the methods fails (via goto abort), it should return 0 and not 1.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 351 bytes --]
diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c
index 805b64d..7ebb8e8 100644
--- a/drivers/net/pppoe.c
+++ b/drivers/net/pppoe.c
@@ -949,7 +949,7 @@ static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb)
abort:
kfree_skb(skb);
- return 1;
+ return 0;
}
/************************************************************************
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-05 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03 15:02 [PATCH net-next-2.6] [PPPOE] fix return value of __pppoe_xmit() method Rami Rosen
2010-06-05 9:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).