From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: timo.teras@iki.fi, netdev@vger.kernel.org,
edward_hsu@realtek.com.tw, hayeswang@realtek.com
Subject: Re: [PATCH] r8169: fix random mdio_write failures
Date: Sun, 06 Jun 2010 15:39:11 -0700 (PDT) [thread overview]
Message-ID: <20100606.153911.45884246.davem@davemloft.net> (raw)
In-Reply-To: <20100605124103.GA3213@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Sat, 5 Jun 2010 14:41:03 +0200
> Timo Teräs <timo.teras@iki.fi> :
> [...]
>> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
>> index 217e709..03a8318 100644
>> --- a/drivers/net/r8169.c
>> +++ b/drivers/net/r8169.c
>> @@ -559,6 +559,11 @@ static void mdio_write(void __iomem *ioaddr, int reg_addr, int value)
>> break;
>> udelay(25);
>> }
>> + /*
>> + * Some configurations require a small delay even after the write
>> + * completed indication or the next write might fail.
>> + */
>> + udelay(25);
>
> Acked-off-by: Francois Romieu <romieu@fr.zoreil.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2010-06-06 22:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 12:10 still having r8169 woes with XID 18000000 Timo Teräs
2010-06-04 12:36 ` Phil Sutter
2010-06-04 13:02 ` Timo Teräs
2010-06-04 13:43 ` Phil Sutter
2010-06-04 17:31 ` Timo Teräs
2010-06-04 20:24 ` Timo Teräs
2010-06-05 7:39 ` [PATCH] " Timo Teräs
2010-06-05 9:02 ` David Miller
2010-06-05 9:13 ` Eric Dumazet
2010-06-05 9:21 ` Timo Teräs
2010-06-05 10:21 ` [PATCH] r8169: fix random mdio_write failures Timo Teräs
2010-06-05 12:41 ` Francois Romieu
2010-06-06 22:39 ` David Miller [this message]
2010-06-07 9:26 ` hayeswang
2010-06-07 21:51 ` Francois Romieu
2010-06-08 6:06 ` Timo Teräs
2010-06-08 6:26 ` Francois Romieu
2010-06-09 2:47 ` hayeswang
2010-06-09 5:22 ` [PATCH] r8169: fix mdio_read and update mdio_write according to hw specs Timo Teräs
2010-06-09 6:18 ` Francois Romieu
2010-06-10 0:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100606.153911.45884246.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edward_hsu@realtek.com.tw \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).