From: David Miller <davem@davemloft.net>
To: jussi.kivilinna@mbnet.fi
Cc: netdev@vger.kernel.org, dhollis@davehollis.com
Subject: Re: [PATCH] asix: check packet size against mtu+ETH_HLEN instead of ETH_FRAME_LEN
Date: Mon, 07 Jun 2010 00:57:01 -0700 (PDT) [thread overview]
Message-ID: <20100607.005701.220044418.davem@davemloft.net> (raw)
In-Reply-To: <20100606233531.23585.10292.stgit@fate.lan>
From: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Date: Mon, 07 Jun 2010 02:35:31 +0300
> Driver checks received packet is too large in asix_rx_fixup() and fails if it is. Problem is
> that MTU might be set larger than 1500 and asix fails to work correctly with VLAN tagged
> packets. The check should be 'dev->net->mtu + ETH_HLEN' instead.
>
> Tested with AX88772.
>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Applied, thanks.
prev parent reply other threads:[~2010-06-07 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 23:35 [PATCH] asix: check packet size against mtu+ETH_HLEN instead of ETH_FRAME_LEN Jussi Kivilinna
2010-06-07 7:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100607.005701.220044418.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhollis@davehollis.com \
--cc=jussi.kivilinna@mbnet.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).