From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next-2.6] ipv4: avoid two atomic ops in
 ip_rt_redirect()
Date: Mon, 07 Jun 2010 21:51:19 -0700 (PDT)
Message-ID: <20100607.215119.176661892.davem@davemloft.net>
References: <1275916983.2545.73.camel@edumazet-laptop>
	<20100607.212622.267982352.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: eric.dumazet@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:45175
	"EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750739Ab0FHEvJ (ORCPT
	<rfc822;netdev@vger.kernel.org>); Tue, 8 Jun 2010 00:51:09 -0400
In-Reply-To: <20100607.212622.267982352.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: David Miller <davem@davemloft.net>
Date: Mon, 07 Jun 2010 21:26:22 -0700 (PDT)

> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 07 Jun 2010 15:23:03 +0200
> 
>> in_dev_get() -> __in_dev_get_rcu() in a rcu protected function.
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> 
> Applied.

I needed to modify this patch to get it to build.

You left a code label with no code afterwards at the end of
ip_rt_redirect() when CONFIG_IP_ROUTE_VERBOSE is disabled,
which breaks the build.

I fixed it by adding a semicolon.