* [patch] caif: fix a couple range checks
@ 2010-06-07 14:51 Dan Carpenter
2010-06-09 9:11 ` Sjur BRENDELAND
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2010-06-07 14:51 UTC (permalink / raw)
To: Sjur Braendeland; +Cc: David S. Miller, netdev, kernel-janitors
The extra ! character means that these conditions are always false.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/caif/cfveil.c b/net/caif/cfveil.c
index 0fd827f..e04f7d9 100644
--- a/net/caif/cfveil.c
+++ b/net/caif/cfveil.c
@@ -84,7 +84,7 @@ static int cfvei_transmit(struct cflayer *layr, struct cfpkt *pkt)
return ret;
caif_assert(layr->dn != NULL);
caif_assert(layr->dn->transmit != NULL);
- if (!cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) {
+ if (cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) {
pr_warning("CAIF: %s(): Packet too large - size=%d\n",
__func__, cfpkt_getlen(pkt));
return -EOVERFLOW;
diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c
index cd2830f..fd27b17 100644
--- a/net/caif/cfrfml.c
+++ b/net/caif/cfrfml.c
@@ -83,7 +83,7 @@ static int cfrfml_transmit(struct cflayer *layr, struct cfpkt *pkt)
if (!cfsrvl_ready(service, &ret))
return ret;
- if (!cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) {
+ if (cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) {
pr_err("CAIF: %s():Packet too large - size=%d\n",
__func__, cfpkt_getlen(pkt));
return -EOVERFLOW;
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [patch] caif: fix a couple range checks
2010-06-07 14:51 [patch] caif: fix a couple range checks Dan Carpenter
@ 2010-06-09 9:11 ` Sjur BRENDELAND
2010-06-09 23:19 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Sjur BRENDELAND @ 2010-06-09 9:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: David S. Miller, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
> From: Dan Carpenter [mailto:error27@gmail.com]
>
> The extra ! character means that these conditions are always false.
Looks good, thanks. This is embarrassing, I should caught this ages ago.
Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/net/caif/cfveil.c b/net/caif/cfveil.c
> index 0fd827f..e04f7d9 100644
> --- a/net/caif/cfveil.c
> +++ b/net/caif/cfveil.c
> @@ -84,7 +84,7 @@ static int cfvei_transmit(struct cflayer *layr,
> struct cfpkt *pkt)
> return ret;
> caif_assert(layr->dn != NULL);
> caif_assert(layr->dn->transmit != NULL);
> - if (!cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) {
> + if (cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) {
> pr_warning("CAIF: %s(): Packet too large - size=%d\n",
> __func__, cfpkt_getlen(pkt));
> return -EOVERFLOW;
> diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c
> index cd2830f..fd27b17 100644
> --- a/net/caif/cfrfml.c
> +++ b/net/caif/cfrfml.c
> @@ -83,7 +83,7 @@ static int cfrfml_transmit(struct cflayer *layr,
> struct cfpkt *pkt)
> if (!cfsrvl_ready(service, &ret))
> return ret;
>
> - if (!cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) {
> + if (cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) {
> pr_err("CAIF: %s():Packet too large - size=%d\n",
> __func__, cfpkt_getlen(pkt));
> return -EOVERFLOW;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] caif: fix a couple range checks
2010-06-09 9:11 ` Sjur BRENDELAND
@ 2010-06-09 23:19 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-06-09 23:19 UTC (permalink / raw)
To: sjur.brandeland; +Cc: error27, netdev, kernel-janitors
From: Sjur BRENDELAND <sjur.brandeland@stericsson.com>
Date: Wed, 9 Jun 2010 11:11:38 +0200
>> From: Dan Carpenter [mailto:error27@gmail.com]
>>
>> The extra ! character means that these conditions are always false.
>
>
> Looks good, thanks. This is embarrassing, I should caught this ages ago.
> Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied, thanks guys.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-09 23:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-07 14:51 [patch] caif: fix a couple range checks Dan Carpenter
2010-06-09 9:11 ` Sjur BRENDELAND
2010-06-09 23:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).