From: Randy Dunlap <randy.dunlap@oracle.com>
To: David Miller <davem@davemloft.net>,
Grant Likely <grant.likely@secretlab.ca>
Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2 -next] niu: always include of_device.h
Date: Wed, 9 Jun 2010 15:44:09 -0700 [thread overview]
Message-ID: <20100609154409.bf024c0c.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20100609.110638.112605100.davem@davemloft.net>
From: Randy Dunlap <randy.dunlap@oracle.com>
The niu driver uses struct of_device when built on any arch, not
only SPARC64, so always #include <linux/of_device.h>.
drivers/net/niu.c:9700: warning: 'struct of_device' declared inside parameter list
drivers/net/niu.c:9700: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/net/niu.c:9716: warning: assignment from incompatible pointer type
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Dave Miller <davem@davemloft.net>
---
drivers/net/niu.c | 3 ---
1 file changed, 3 deletions(-)
--- linux-next-20100609.orig/drivers/net/niu.c
+++ linux-next-20100609/drivers/net/niu.c
@@ -28,10 +28,7 @@
#include <linux/slab.h>
#include <linux/io.h>
-
-#ifdef CONFIG_SPARC64
#include <linux/of_device.h>
-#endif
#include "niu.h"
next prev parent reply other threads:[~2010-06-09 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100609133443.38f1f957.sfr@canb.auug.org.au>
2010-06-09 17:36 ` linux-next: Tree for June 9 (niu) Randy Dunlap
2010-06-09 18:06 ` David Miller
2010-06-09 18:08 ` Randy Dunlap
2010-06-09 22:44 ` [PATCH 1/2 -next] of_device.h: provide struct of_device even when not enabled Randy Dunlap
2010-06-09 23:47 ` Grant Likely
2010-06-09 22:44 ` Randy Dunlap [this message]
2010-06-09 23:45 ` [PATCH 2/2 -next] niu: always include of_device.h Grant Likely
2010-06-10 0:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609154409.bf024c0c.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).