netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: john.r.fastabend@intel.com
Cc: fubar@us.ibm.com, nhorman@tuxdriver.com,
	bonding-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: deliver skbs on inactive slaves to exact matches
Date: Thu, 10 Jun 2010 22:31:13 -0700 (PDT)	[thread overview]
Message-ID: <20100610.223113.200377963.davem@davemloft.net> (raw)
In-Reply-To: <20100603193011.4916.12354.stgit@jf-dev2-dcblab>

From: John Fastabend <john.r.fastabend@intel.com>
Date: Thu, 03 Jun 2010 12:30:11 -0700

> Currently, the accelerated receive path for VLAN's will
> drop packets if the real device is an inactive slave and
> is not one of the special pkts tested for in
> skb_bond_should_drop().  This behavior is different then
> the non-accelerated path and for pkts over a bonded vlan.
 ...
> This patch adds a sk_buff flag which is used for tagging
> skbs that would previously been dropped and allows the
> skb to continue to skb_netif_recv().  Here we add
> logic to check for the deliver_no_wcard flag and if it
> is set only deliver to handlers that match exactly.  This
> makes both paths above consistent and gives pkt handlers
> a way to identify skbs that come from inactive slaves.
> Without this patch in some configurations skbs will be
> delivered to handlers with exact matches and in others
> be dropped out right in the vlan path.
 ...
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>

I can't figure out a better way to fix this myself so I've
applied your patch, thanks John!

  reply	other threads:[~2010-06-11  5:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03 19:30 [PATCH v2] net: deliver skbs on inactive slaves to exact matches John Fastabend
2010-06-11  5:31 ` David Miller [this message]
2010-06-14 13:21 ` Michael S. Tsirkin
2010-06-14 13:34   ` Eric Dumazet
2010-06-14 13:38     ` Eric Dumazet
2010-06-14 14:10       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100610.223113.200377963.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bonding-devel@lists.sourceforge.net \
    --cc=fubar@us.ibm.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).