From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: shemminger@vyatta.com, arnd@arndb.de, netdev@vger.kernel.org,
linux-net-drivers@solarflare.com
Subject: Re: [PATCHv3 1/2] net: Enable 64-bit net device statistics on 32-bit architectures
Date: Sat, 12 Jun 2010 15:54:54 -0700 (PDT) [thread overview]
Message-ID: <20100612.155454.108790680.davem@davemloft.net> (raw)
In-Reply-To: <1276017594.2185.11.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 08 Jun 2010 18:19:54 +0100
> Use struct rtnl_link_stats64 as the statistics structure.
>
> On 32-bit architectures, insert 32 bits of padding after/before each
> field of struct net_device_stats to make its layout compatible with
> struct rtnl_link_stats64. Add an anonymous union in net_device; move
> stats into the union and add struct rtnl_link_stats64 stats64.
>
> Add net_device_ops::ndo_get_stats64, implementations of which will
> return a pointer to struct rtnl_link_stats64. Drivers that implement
> this operation must not update the structure asynchronously.
>
> Change dev_get_stats() to call ndo_get_stats64 if available, and to
> return a pointer to struct rtnl_link_stats64. Change callers of
> dev_get_stats() accordingly.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
prev parent reply other threads:[~2010-06-12 22:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 17:19 [PATCHv3 1/2] net: Enable 64-bit net device statistics on 32-bit architectures Ben Hutchings
2010-06-08 17:21 ` [PATCHv3 2/2] sfc: Implement 64-bit net device statistics on all architectures Ben Hutchings
2010-06-12 22:55 ` David Miller
2010-07-05 18:16 ` Eric Dumazet
2010-07-05 18:31 ` Eric Dumazet
2010-07-05 20:05 ` [PATCH net-next-2.6 V2] net: fix 64 bit counters on 32 bit arches Eric Dumazet
2010-07-07 21:36 ` David Miller
2010-07-07 22:41 ` David Miller
2010-07-08 5:18 ` Eric Dumazet
2010-07-07 19:56 ` [PATCHv3 2/2] sfc: Implement 64-bit net device statistics on all architectures David Miller
2010-06-12 22:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100612.155454.108790680.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).