From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] inetpeer: various changes
Date: Mon, 14 Jun 2010 23:13:31 -0700 (PDT) [thread overview]
Message-ID: <20100614.231331.112591806.davem@davemloft.net> (raw)
In-Reply-To: <1276580121.30434.322.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 15 Jun 2010 07:35:21 +0200
> Try to reduce cache line contentions in peer management, to reduce IP
> defragmentation overhead.
>
> - peer_fake_node is marked 'const' to make sure its not modified.
> (tested with CONFIG_DEBUG_RODATA=y)
>
> - Group variables in two structures to reduce number of dirtied cache
> lines. One named "peers" for avl tree root, its number of entries, and
> associated lock. (candidate for RCU conversion)
>
> - A second one named "unused_peers" for unused list and its lock
>
> - Add a !list_empty() test in unlink_from_unused() to avoid taking lock
> when entry is not unused.
>
> - Use atomic_dec_and_lock() in inet_putpeer() to avoid taking lock in
> some cases.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
prev parent reply other threads:[~2010-06-15 6:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 5:35 [PATCH net-next-2.6] inetpeer: various changes Eric Dumazet
2010-06-15 6:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614.231331.112591806.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox