From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Magnus Damm <damm@opensource.se>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Paul Mundt <lethal@linux-sh.org>, Dmitry Torokhov <dtor@mail.ru>,
Eric Miao <eric.y.miao@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] Driver core: reduce duplicated code
Date: Tue, 15 Jun 2010 11:05:00 +0200 [thread overview]
Message-ID: <20100615090500.GA17595@pengutronix.de> (raw)
In-Reply-To: <1276591677-4678-2-git-send-email-u.kleine-koenig@pengutronix.de>
Hello,
On Tue, Jun 15, 2010 at 10:47:56AM +0200, Uwe Kleine-König wrote:
> This makes the two similar functions platform_device_register_simple
> and platform_device_register_data one line inline functions using a new
> generic function platform_device_register_resndata.
I forgot to add some comments to this mail, ... sorry.
- I'm not completely happy with the name of the new function. If
someone has a better name please tell me.
- can platform_device_register_resndata be moved to __init_or_module?
- I moved the kernel docs to the header but didn't test if they are
picked up when generating docs. Even if not, there is no better
place, is there?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-06-15 9:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1276591677-4678-1-git-send-email-u.kleine-koenig@pengutronix.de>
2010-06-15 8:47 ` [PATCH 2/2] Driver core: reduce duplicated code Uwe Kleine-König
2010-06-15 9:05 ` Uwe Kleine-König [this message]
2010-06-16 20:53 ` Greg KH
2010-06-18 7:39 ` Uwe Kleine-König
2010-06-21 14:11 ` [PATCH 2/2 v2] " Uwe Kleine-König
2010-06-21 21:38 ` Greg KH
2010-06-22 5:23 ` Uwe Kleine-König
2010-06-28 4:55 ` Eric Miao
2010-06-28 5:16 ` Uwe Kleine-König
2010-06-28 5:27 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615090500.GA17595@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=damm@opensource.se \
--cc=dtor@mail.ru \
--cc=eric.y.miao@gmail.com \
--cc=gregkh@suse.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).