From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] inetpeer: restore small inet_peer structures
Date: Wed, 16 Jun 2010 11:56:18 -0700 (PDT) [thread overview]
Message-ID: <20100616.115618.71114885.davem@davemloft.net> (raw)
In-Reply-To: <1276699933.2632.102.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 16 Jun 2010 16:52:13 +0200
> Addition of rcu_head to struct inet_peer added 16bytes on 64bit arches.
>
> Thats a bit unfortunate, since old size was exactly 64 bytes.
>
> This can be solved, using an union between this rcu_head an four fields,
> that are normally used only when a refcount is taken on inet_peer.
> rcu_head is used only when refcnt=-1, right before structure freeing.
>
> Add a inet_peer_refcheck() function to check this assertion for a while.
>
> We can bring back SLAB_HWCACHE_ALIGN qualifier in kmem cache creation.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
prev parent reply other threads:[~2010-06-16 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 14:52 [PATCH net-next-2.6] inetpeer: restore small inet_peer structures Eric Dumazet
2010-06-16 18:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100616.115618.71114885.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).