From: David Miller <davem@davemloft.net>
To: JBottomley@Novell.com
Cc: netdev@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp,
mchan@broadcom.com
Subject: Re: bnx2 fails to compile on parisc because of missing get_dma_ops()
Date: Wed, 16 Jun 2010 18:16:32 -0700 (PDT) [thread overview]
Message-ID: <20100616.181632.27807395.davem@davemloft.net> (raw)
In-Reply-To: <1276737229.2847.853.camel@mulgrave.site>
From: James Bottomley <JBottomley@Novell.com>
Date: Wed, 16 Jun 2010 20:13:49 -0500
> However, this code in bnx2.c:
>
> if (!get_dma_ops(&pdev->dev)->sync_single_for_cpu) {
> next_rx_buf =
> &rxr->rx_buf_ring[
> RX_RING_IDX(NEXT_RX_BD(sw_cons))];
> prefetch(next_rx_buf->desc);
> }
>
> Looks remarkably fragile: what exactly is it trying to do?
>
> The commit that causes the problem:
>
> commit a33fa66bcf365ffe5b79d1ae1d3582cc261ae56e
> Author: Michael Chan <mchan@broadcom.com>
> Date: Thu May 6 08:58:13 2010 +0000
>
> bnx2: Add prefetches to rx path.
>
> Looks fairly innocuous by the description.
>
> Should parisc have a get_dma_ops()? We don't need one because our dma
> ops are per platform not per bus.
I think asking for get_dma_ops() directly in a driver is dodgy at
best, especially one that is meant to compile on any PCI supporting
system. At least right now.
next prev parent reply other threads:[~2010-06-17 1:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 1:13 bnx2 fails to compile on parisc because of missing get_dma_ops() James Bottomley
2010-06-17 1:16 ` David Miller [this message]
2010-06-17 12:13 ` FUJITA Tomonori
2010-06-17 1:17 ` Mike Frysinger
2010-06-17 3:53 ` Michael Chan
2010-06-17 4:00 ` Mike Frysinger
2010-06-17 4:03 ` Paul Mundt
2010-06-17 4:10 ` Michael Chan
2010-06-17 6:24 ` Michael Chan
2010-06-17 12:21 ` FUJITA Tomonori
2010-06-17 14:36 ` David Miller
2010-06-17 14:50 ` FUJITA Tomonori
2010-06-17 15:30 ` Paul Mundt
2010-06-22 6:30 ` FUJITA Tomonori
2010-06-22 17:14 ` Grant Grundler
2010-06-22 17:26 ` James Bottomley
2010-06-23 0:38 ` FUJITA Tomonori
2010-06-17 4:20 ` James Bottomley
2010-06-17 12:13 ` FUJITA Tomonori
2010-06-17 12:54 ` Michael Chan
2010-06-17 13:12 ` James Bottomley
2010-06-17 13:30 ` Michael Chan
2010-06-17 13:36 ` James Bottomley
2010-06-17 14:05 ` FUJITA Tomonori
2010-06-17 14:42 ` Michael Chan
2010-06-17 14:50 ` FUJITA Tomonori
2010-06-17 15:52 ` David Miller
2010-06-17 12:13 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100616.181632.27807395.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=JBottomley@Novell.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).