From: David Miller <davem@davemloft.net>
To: chf.fritz@googlemail.com
Cc: strakh@ispras.ru, philb@gnu.org, craigs@ineluki.apana.org.au,
tridge@nimbus.anu.edu.au, Alan.Cox@linux.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: BUG: double spinlock in "drivers/net/3c505.c"
Date: Thu, 17 Jun 2010 20:12:16 -0700 (PDT) [thread overview]
Message-ID: <20100617.201216.115931147.davem@davemloft.net> (raw)
In-Reply-To: <1276003605.3916.14.camel@lovely>
From: Christoph Fritz <chf.fritz@googlemail.com>
Date: Tue, 08 Jun 2010 15:26:45 +0200
> On Mon, 2010-06-07 at 15:17 +0400, Alexander Strakh wrote:
>> KERNEL_VERSION: 2.6.35-rc1
>> SUBJECT: duble spinlock in function elp_start_xmit
>
> Not only in elp_start_xmit. This driver is for a pretty old and slow isa
> ethernet card and I think nobody cares. To quote a comment from the
> source: "[...] the concurrency protection is particularly awful".
Indeed, I spent some time trying to unravel the locking mess
for these call chains to check_3c505_dma() and it was just
too much to sanely cure.
prev parent reply other threads:[~2010-06-18 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 11:17 BUG: double spinlock in "drivers/net/3c505.c" Alexander Strakh
2010-06-08 13:26 ` Christoph Fritz
2010-06-18 3:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617.201216.115931147.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Alan.Cox@linux.org \
--cc=chf.fritz@googlemail.com \
--cc=craigs@ineluki.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philb@gnu.org \
--cc=strakh@ispras.ru \
--cc=tridge@nimbus.anu.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).