From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
bruce.w.allan@intel.com
Subject: Re: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopback setup code
Date: Fri, 18 Jun 2010 22:15:12 -0700 (PDT) [thread overview]
Message-ID: <20100618.221512.102550313.davem@davemloft.net> (raw)
In-Reply-To: <20100616232523.4834.84849.stgit@localhost.localdomain>
I've applied this series however:
1) Please address Ben's concerns about turning EEE on by default
given that standardization is not complete yet.
2) I hate module parameters, I'd rather you create a new ethtool
feature bit and thus allow the setting to be modified at run
time. Please create a new ethtool control flag, and remove
this module option.
Thanks.
next prev parent reply other threads:[~2010-06-19 5:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 23:25 [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopback setup code Jeff Kirsher
2010-06-16 23:26 ` [net-next-2.6 PATCH 2/8] e1000e: cleanup e1000_sw_lcd_config_ich8lan() Jeff Kirsher
2010-06-16 23:26 ` [net-next-2.6 PATCH 3/8] e1000e: separate out PHY statistics register updates Jeff Kirsher
2010-06-16 23:27 ` [net-next-2.6 PATCH 4/8] e1000e: fix check for manageability on ICHx/PCH Jeff Kirsher
2010-06-16 23:27 ` [net-next-2.6 PATCH 5/8] e1000e: initial support for 82579 LOMs Jeff Kirsher
2010-06-16 23:27 ` [net-next-2.6 PATCH 6/8] e1000e: enable support for EEE on 82579 Jeff Kirsher
2010-06-16 23:52 ` Ben Hutchings
2010-06-16 23:28 ` [net-next-2.6 PATCH 7/8] e1000e: update copyright information Jeff Kirsher
2010-06-16 23:28 ` [net-next-2.6 PATCH 8/8] e1000e: update driver version number Jeff Kirsher
2010-06-19 5:15 ` David Miller [this message]
2010-06-20 7:32 ` [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopback setup code Jeff Kirsher
2010-06-20 21:48 ` David Miller
2010-06-30 22:41 ` Allan, Bruce W
2010-06-30 23:06 ` David Miller
2010-07-01 15:55 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100618.221512.102550313.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@novell.com \
--cc=bruce.w.allan@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).