From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: sjurbr@gmail.com, netdev@vger.kernel.org, marcel@holtmann.org,
daniel.martensson@stericsson.com, linus.walleij@stericsson.com
Subject: Re: [PATCH] caif: Add CAIF-SPI Protocol driver.
Date: Sun, 20 Jun 2010 20:39:56 -0700 (PDT) [thread overview]
Message-ID: <20100620.203956.15250412.davem@davemloft.net> (raw)
In-Reply-To: <1276794164-20455-1-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Thu, 17 Jun 2010 19:02:44 +0200
> +ifeq ($(CONFIG_CAIF_SPI_SYNC),y)
> +CAIF_SPI_FLAGS := -DCONFIG_CAIF_SPI_SYNC
> +endif
> +
You should never set CONFIG_* defines from the Makefile
commands, always set them in your Kconfig statements.
prev parent reply other threads:[~2010-06-21 3:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 17:02 [PATCH] caif: Add CAIF-SPI Protocol driver sjur.brandeland
2010-06-21 3:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100620.203956.15250412.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel.martensson@stericsson.com \
--cc=linus.walleij@stericsson.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
--cc=sjurbr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).