* [PATCH] NET: MIPSsim: Fix modpost warning.
@ 2010-06-21 13:44 Ralf Baechle
2010-06-21 20:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2010-06-21 13:44 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
$ make CONFIG_DEBUG_SECTION_MISMATCH=y
[...]
WARNING: drivers/net/built-in.o(.data+0x0): Section mismatch in reference from the variable mipsnet_driver to the function .init.text:mipsnet_probe()
The variable mipsnet_driver references
the function __init mipsnet_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
[...]
Fixed by making mipsnet_probe __devinit.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
drivers/net/mipsnet.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/mipsnet.c b/drivers/net/mipsnet.c
index 8e9704f..869f0ea 100644
--- a/drivers/net/mipsnet.c
+++ b/drivers/net/mipsnet.c
@@ -247,7 +247,7 @@ static const struct net_device_ops mipsnet_netdev_ops = {
.ndo_set_mac_address = eth_mac_addr,
};
-static int __init mipsnet_probe(struct platform_device *dev)
+static int __devinit mipsnet_probe(struct platform_device *dev)
{
struct net_device *netdev;
int err;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NET: MIPSsim: Fix modpost warning.
2010-06-21 13:44 [PATCH] NET: MIPSsim: Fix modpost warning Ralf Baechle
@ 2010-06-21 20:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-06-21 20:40 UTC (permalink / raw)
To: ralf; +Cc: netdev
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 21 Jun 2010 14:44:50 +0100
> $ make CONFIG_DEBUG_SECTION_MISMATCH=y
> [...]
> WARNING: drivers/net/built-in.o(.data+0x0): Section mismatch in reference from the variable mipsnet_driver to the function .init.text:mipsnet_probe()
> The variable mipsnet_driver references
> the function __init mipsnet_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
> [...]
>
> Fixed by making mipsnet_probe __devinit.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Applied, thanks Ralf.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-21 20:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-21 13:44 [PATCH] NET: MIPSsim: Fix modpost warning Ralf Baechle
2010-06-21 20:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).