From: David Miller <davem@davemloft.net>
To: liberty@extricom.com
Cc: galak@kernel.crashing.org, netdev@vger.kernel.org
Subject: Re: [PATCH] gainfar.c : skb_over_panic
Date: Mon, 21 Jun 2010 13:47:33 -0700 (PDT) [thread overview]
Message-ID: <20100621.134733.115953029.davem@davemloft.net> (raw)
In-Reply-To: <4C1F2D39.9050804@extricom.com>
From: Eran Liberty <liberty@extricom.com>
Date: Mon, 21 Jun 2010 12:13:29 +0300
> I have compared the suggested patch with what the function
> skb_recycle_check() does. Both patch and skb_recycle_check()
> have skb_reset_tail_pointer(). While the patch zero only skb->len,
> skb_recycle_check()
> clears the whole skb (up to tail). On top of that skb_recycle_check()
> preforms a whole set of other checks and cleanups. The question is,
> which action is MORE correct: the pin-point action of the patch
> suggested or the broader checks of skb_recycle_check() function?
At this stage in the code we know exactly what modifications, if any,
we've made to the SKB state. Therefore it makes sense to only fix
up the tiny amount of changes we've made instead of doing a complete
skb_recycle_call() which seems entirely excessive in this situation.
next prev parent reply other threads:[~2010-06-21 20:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 16:32 [PATCH] gainfar.c : skb_over_panic Eran Liberty
2010-06-17 19:20 ` David Miller
2010-06-21 9:13 ` Eran Liberty
2010-06-21 20:47 ` David Miller [this message]
2010-06-23 17:52 ` Eran Liberty
2010-06-23 18:27 ` David Miller
2010-06-23 15:03 ` Eran Liberty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100621.134733.115953029.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=galak@kernel.crashing.org \
--cc=liberty@extricom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).