* [PATCH] hso: remove setting of low_latency flag
@ 2010-06-11 9:17 f.aben
2010-06-17 9:03 ` Filip Aben
0 siblings, 1 reply; 3+ messages in thread
From: f.aben @ 2010-06-11 9:17 UTC (permalink / raw)
To: davem; +Cc: linux-usb, netdev, j.dumon
This patch removes the setting of the low_latency flag.
tty_flip_buffer_push() is occasionally being called in irq context, which
causes a hang if the low_latency flag is set.
Removing the low_latency flag only seems to impact the flush to ldisc,
which will now be put on a workqueue.
Signed-off-by: Filip Aben <f.aben@option.com>
---
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 0a3c41f..4dd2351 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1334,7 +1334,6 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp)
/* check for port already opened, if not set the termios */
serial->open_count++;
if (serial->open_count == 1) {
- tty->low_latency = 1;
serial->rx_state = RX_IDLE;
/* Force default termio settings */
_hso_serial_set_termios(tty, NULL);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hso: remove setting of low_latency flag
2010-06-11 9:17 [PATCH] hso: remove setting of low_latency flag f.aben
@ 2010-06-17 9:03 ` Filip Aben
2010-06-22 17:10 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Filip Aben @ 2010-06-17 9:03 UTC (permalink / raw)
To: davem, gregkh; +Cc: linux-usb, netdev
Hi all,
Did the patch below get accepted or is there a problem with it ?
Haven't seen it appearing in any git trees so far.
Thanks,
Filip-
On Fri, 2010-06-11 at 11:17 +0200, f.aben@option.com wrote:
> This patch removes the setting of the low_latency flag.
> tty_flip_buffer_push() is occasionally being called in irq context, which
> causes a hang if the low_latency flag is set.
> Removing the low_latency flag only seems to impact the flush to ldisc,
> which will now be put on a workqueue.
>
> Signed-off-by: Filip Aben <f.aben@option.com>
>
> ---
>
> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
> index 0a3c41f..4dd2351 100644
> --- a/drivers/net/usb/hso.c
> +++ b/drivers/net/usb/hso.c
> @@ -1334,7 +1334,6 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp)
> /* check for port already opened, if not set the termios */
> serial->open_count++;
> if (serial->open_count == 1) {
> - tty->low_latency = 1;
> serial->rx_state = RX_IDLE;
> /* Force default termio settings */
> _hso_serial_set_termios(tty, NULL);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hso: remove setting of low_latency flag
2010-06-17 9:03 ` Filip Aben
@ 2010-06-22 17:10 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-06-22 17:10 UTC (permalink / raw)
To: f.aben; +Cc: gregkh, linux-usb, netdev
From: Filip Aben <f.aben@option.com>
Date: Thu, 17 Jun 2010 11:03:35 +0200
> Did the patch below get accepted or is there a problem with it ?
> Haven't seen it appearing in any git trees so far.
I've applied your patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-22 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-11 9:17 [PATCH] hso: remove setting of low_latency flag f.aben
2010-06-17 9:03 ` Filip Aben
2010-06-22 17:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).