From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John W. Linville" Subject: Re: [PATCH 1/5 v2]wireless:hostap_main.c warning: variable 'iface' set but not used Date: Tue, 22 Jun 2010 14:13:20 -0400 Message-ID: <20100622181320.GD2583@tuxdriver.com> References: <1277157733-14071-1-git-send-email-justinmattock@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Justin P. Mattock" Return-path: Content-Disposition: inline In-Reply-To: <1277157733-14071-1-git-send-email-justinmattock@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Jun 21, 2010 at 03:02:13PM -0700, Justin P. Mattock wrote: > This is a resend from version one due to trying a different approach > than the original(probably important to leave netdev_priv() in). > > In any case have a look, if there's another approach let me know > and ill test it out. The below patch fixes a warning im seeing > when compiling with gcc 4.6.0 > > CC [M] drivers/net/wireless/hostap/hostap_main.o > drivers/net/wireless/hostap/hostap_main.c: In function 'hostap_set_multicast_list_queue': > drivers/net/wireless/hostap/hostap_main.c:744:27: warning: variable 'iface' set but not used > Signed-off-by: Justin P. Mattock I already applied the other version to wireless-next-2.6. I can't imagine what you mean to accomplish by leaving in a call to netdev_priv w/o assigning the result to something. John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.