From: David Miller <davem@davemloft.net>
To: brandon@ifup.org
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: enable rx/tx in sky2_phy_reinit()
Date: Wed, 23 Jun 2010 14:37:47 -0700 (PDT) [thread overview]
Message-ID: <20100623.143747.260104620.davem@davemloft.net> (raw)
In-Reply-To: <20100617022158.GA4135@jenkins.ifup.org>
From: Brandon Philips <brandon@ifup.org>
Date: Wed, 16 Jun 2010 19:21:58 -0700
> sky2_phy_reinit is called by the ethtool helpers sky2_set_settings,
> sky2_nway_reset and sky2_set_pauseparam when netif_running.
>
> However, at the end of sky2_phy_init GM_GP_CTRL has GM_GPCR_RX_ENA and
> GM_GPCR_TX_ENA cleared. So, doing these commands causes the device to
> stop working:
>
> $ ethtool -r eth0
> $ ethtool -A eth0 autoneg off
>
> Fix this issue by enabling Rx/Tx after running sky2_phy_init in
> sky2_phy_reinit.
>
> Signed-off-by: Brandon Philips <bphilips@suse.de>
> Tested-by: Brandon Philips <bphilips@suse.de>
> Cc: stable@kernel.org
Applied, thanks for fixing this bug.
prev parent reply other threads:[~2010-06-23 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 2:21 [PATCH] sky2: enable rx/tx in sky2_phy_reinit() Brandon Philips
2010-06-22 14:57 ` Mike McCormack
2010-06-23 17:00 ` Brandon Philips
2010-07-12 11:04 ` Brandon Philips
2010-07-12 15:48 ` Stephen Hemminger
2010-06-23 21:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100623.143747.260104620.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brandon@ifup.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).