From: Florian Westphal <fw@strlen.de>
To: Jiri Pirko <jpirko@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kaber@trash.net
Subject: Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed
Date: Wed, 23 Jun 2010 20:46:11 +0200 [thread overview]
Message-ID: <20100623184611.GG27132@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <20100623183503.GE2687@psychotron.bos.redhat.com>
Jiri Pirko <jpirko@redhat.com> wrote:
> diff --git a/net/netfilter/nf_tproxy_core.c b/net/netfilter/nf_tproxy_core.c
> index 5490fc3..ec6737c 100644
> --- a/net/netfilter/nf_tproxy_core.c
> +++ b/net/netfilter/nf_tproxy_core.c
> @@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
> return 0;
> }
>
> +static void __exit nf_tproxy_exit(void)
> +{
> +}
> +
> module_init(nf_tproxy_init);
> +module_exit(nf_tproxy_exit);
tproxy assigns skb->destructor, what prevents module unload while such skbs may
still be around?
next prev parent reply other threads:[~2010-06-23 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 18:35 [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed Jiri Pirko
2010-06-23 18:46 ` Florian Westphal [this message]
2010-06-23 18:55 ` David Miller
2010-06-24 15:29 ` Patrick McHardy
2010-06-25 7:56 ` KOVACS Krisztian
2010-06-29 6:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100623184611.GG27132@Chamillionaire.breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).