netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 1/1] fix "netpoll: Allow netpoll_setup/cleanup recursion"
@ 2010-06-25  3:54 akpm
  2010-06-25  4:27 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2010-06-25  3:54 UTC (permalink / raw)
  To: davem; +Cc: netdev, akpm, herbert

From: Andrew Morton <akpm@linux-foundation.org>

Remove rtnl_unlock() which had no corresponding rtnl_lock().

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/core/netpoll.c |    1 -
 1 file changed, 1 deletion(-)

diff -puN net/core/netpoll.c~fix-netpoll-allow-netpoll_setup-cleanup-recursion net/core/netpoll.c
--- a/net/core/netpoll.c~fix-netpoll-allow-netpoll_setup-cleanup-recursion
+++ a/net/core/netpoll.c
@@ -748,7 +748,6 @@ int __netpoll_setup(struct netpoll *np)
 
 	/* last thing to do is link it to the net device structure */
 	rcu_assign_pointer(ndev->npinfo, npinfo);
-	rtnl_unlock();
 
 	return 0;
 
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 1/1] fix "netpoll: Allow netpoll_setup/cleanup recursion"
  2010-06-25  3:54 [patch 1/1] fix "netpoll: Allow netpoll_setup/cleanup recursion" akpm
@ 2010-06-25  4:27 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-06-25  4:27 UTC (permalink / raw)
  To: akpm; +Cc: netdev, herbert

From: akpm@linux-foundation.org
Date: Thu, 24 Jun 2010 20:54:01 -0700

> From: Andrew Morton <akpm@linux-foundation.org>
> 
> Remove rtnl_unlock() which had no corresponding rtnl_lock().
> 
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

I found a time machine and applied this before you even posted
it here :-)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-06-25  4:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-25  3:54 [patch 1/1] fix "netpoll: Allow netpoll_setup/cleanup recursion" akpm
2010-06-25  4:27 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).