From: "Michael S. Tsirkin" <mst@redhat.com>
To: Herbert Xu <herbert.xu@redhat.com>
Cc: netdev@vger.kernel.org
Subject: dhclient, checksum and tap
Date: Fri, 25 Jun 2010 18:10:08 +0300 [thread overview]
Message-ID: <20100625151008.GA17911@redhat.com> (raw)
Hi!
I've been looking at the issue of checksum on
dhcp packets: to recap, 8dc4194474159660d7f37c495e3fc3f10d0db8cc
added a way for af_packet sockets to get the packet status.
Unfortunately not all dhcp clients caught up with
this development, so they are still broken
when both server and client run on the same host,
e.g. with bridge+tap.
And of course virtualization adds another way to run
old dhcp clients, so userspace virtio net in qemu has
a hack to detect DHCP and fill in the checksum.
I guess we could add this in vhost, as well.
However, one wonders whether the tap driver is a better place
for this work-around, that would help all users.
Any objections against putting such code in tap?
--
MST
next reply other threads:[~2010-06-25 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 15:10 Michael S. Tsirkin [this message]
2010-06-25 18:21 ` dhclient, checksum and tap David Miller
2010-06-26 21:14 ` Michael S. Tsirkin
2010-06-27 3:03 ` David Miller
2010-06-27 8:24 ` Michael S. Tsirkin
2010-06-28 4:59 ` David Miller
2010-06-27 15:46 ` [PATCH RFC] vhost-net: add dhclient work-around from userspace Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100625151008.GA17911@redhat.com \
--to=mst@redhat.com \
--cc=herbert.xu@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).