From: David Miller <davem@davemloft.net>
To: holger.brunck@keymile.com
Cc: netdev@vger.kernel.org, christopher.varlese@keymile.com,
leoli@freescale.com, avorontsov@ru.mvista.com, tj@kernel.org
Subject: Re: [PATCH] net, ucc_geth: ethtool -d shows phy register values
Date: Sat, 26 Jun 2010 21:20:33 -0700 (PDT) [thread overview]
Message-ID: <20100626.212033.135523015.davem@davemloft.net> (raw)
In-Reply-To: <1276610603-11589-1-git-send-email-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Tue, 15 Jun 2010 16:03:23 +0200
> From: Chris Varlese <christopher.varlese@keymile.com>
>
> Fixes MPC83xx UCC Ethernet driver so ethtool -d dumps values of
> the PHY registers (like other devices do) instead of the UCC registers
> of the MPC83xx.
>
> Signed-off-by: Chris Varlese <christopher.varlese@keymile.com>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
This doesn't look right at all.
ethtool -d dumps "chip registers", not the PHY registers. So the
current code looks correct, not what you're changing it to.
parent reply other threads:[~2010-06-27 4:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1276610603-11589-1-git-send-email-holger.brunck@keymile.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100626.212033.135523015.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avorontsov@ru.mvista.com \
--cc=christopher.varlese@keymile.com \
--cc=holger.brunck@keymile.com \
--cc=leoli@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).