netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] net, ucc_geth: ethtool -d shows phy register values
       [not found] <1276610603-11589-1-git-send-email-holger.brunck@keymile.com>
@ 2010-06-27  4:20 ` David Miller
  0 siblings, 0 replies; only message in thread
From: David Miller @ 2010-06-27  4:20 UTC (permalink / raw)
  To: holger.brunck; +Cc: netdev, christopher.varlese, leoli, avorontsov, tj

From: Holger Brunck <holger.brunck@keymile.com>
Date: Tue, 15 Jun 2010 16:03:23 +0200

> From: Chris Varlese <christopher.varlese@keymile.com>
> 
> Fixes MPC83xx UCC Ethernet driver so ethtool -d dumps values of
> the PHY registers (like other devices do) instead of the UCC registers
> of the MPC83xx.
> 
> Signed-off-by: Chris Varlese <christopher.varlese@keymile.com>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>

This doesn't look right at all.

ethtool -d dumps "chip registers", not the PHY registers.  So the
current code looks correct, not what you're changing it to.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-27  4:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1276610603-11589-1-git-send-email-holger.brunck@keymile.com>
2010-06-27  4:20 ` [PATCH] net, ucc_geth: ethtool -d shows phy register values David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).