From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] syncookies: do not store rcv_wscale in tcp timestamp
Date: Sat, 26 Jun 2010 22:00:46 -0700 (PDT) [thread overview]
Message-ID: <20100626.220046.209981863.davem@davemloft.net> (raw)
In-Reply-To: <1277156925-7295-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Mon, 21 Jun 2010 23:48:44 +0200
> As pointed out by Fernando Gont there is no need to encode rcv_wscale
> into the cookie.
>
> We did not use the restored rcv_wscale anyway; it is recomputed
> via tcp_select_initial_window().
>
> Thus we can save 4 bits in the ts option space by removing rcv_wscale.
> In case window scaling was not supported, we set the (invalid) wscale
> value 0xf.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied.
prev parent reply other threads:[~2010-06-27 5:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 21:48 [PATCH 1/2] syncookies: do not store rcv_wscale in tcp timestamp Florian Westphal
2010-06-21 21:48 ` [PATCH 2/2] syncookies: add support for ECN Florian Westphal
2010-06-27 5:00 ` David Miller
2010-06-23 20:28 ` [PATCH 1/2] syncookies: do not store rcv_wscale in tcp timestamp Hagen Paul Pfeifer
2010-06-24 7:53 ` Florian Westphal
2010-06-24 22:14 ` Hagen Paul Pfeifer
2010-06-27 4:27 ` David Miller
2010-06-27 5:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100626.220046.209981863.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).