From: David Miller <davem@davemloft.net>
To: john.r.fastabend@intel.com
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com
Subject: Re: [RFC net-2.6 PATCH] ixgbe: need to purge skb qdisc lists when changing real_num_tx_queues
Date: Mon, 28 Jun 2010 21:19:30 -0700 (PDT) [thread overview]
Message-ID: <20100628.211930.102546288.davem@davemloft.net> (raw)
In-Reply-To: <20100621052520.2417.65984.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Sun, 20 Jun 2010 22:25:20 -0700
> This patch exports dev_deactivate() symbol.
>
> The qdisc needs to be purged when real_num_tx_queues is
> changed so that skbs do not hit ndo_start_xmit with
> queue_mappings corresponding to tx_rings already freed.
>
> real_num_tx_queues is changed when dynamically enabling or
> disabling DCB or FCoE. To purge the qdisc use dev_deactivate().
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Whatever it is that needs to happen when real_num_tx_queues changes
outght to be transparent to drivers.
Therefore we should hide all of these details behind a well named
interface drivers can call when they need to change real_num_tx_queues.
prev parent reply other threads:[~2010-06-29 4:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 5:25 [RFC net-2.6 PATCH] ixgbe: need to purge skb qdisc lists when changing real_num_tx_queues John Fastabend
2010-06-29 4:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628.211930.102546288.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).