From: David Miller <davem@davemloft.net>
To: greearb@gmail.com
Cc: netdev@vger.kernel.org, greearb@candelatech.com
Subject: Re: [iproute2] iproute2: Allow 'ip addr flush' to loop more than 10 times.
Date: Mon, 28 Jun 2010 23:12:04 -0700 (PDT) [thread overview]
Message-ID: <20100628.231204.229752207.davem@davemloft.net> (raw)
In-Reply-To: <1277790959-28075-1-git-send-email-greearb@candelatech.com>
From: greearb@gmail.com
Date: Mon, 28 Jun 2010 22:55:59 -0700
> From: Ben Greear <greearb@candelatech.com>
>
> The default remains at 10 for backwards compatibility.
>
> For instance:
> # ip addr flush dev eth2
> *** Flush remains incomplete after 10 rounds. ***
> # ip -l 20 addr flush dev eth2
> *** Flush remains incomplete after 20 rounds. ***
> # ip -loops 0 addr flush dev eth2
> #
>
> This is useful for getting rid of large numbers of IP
> addresses in scripts.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
I would suggest to instead add some logic to this code to detect that
forward progress is being made.
I really don't see any value in having a hard limit that triggers on a
bulk delete when no other address changing activity is happening in
the system.
next prev parent reply other threads:[~2010-06-29 6:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 5:55 [iproute2] iproute2: Allow 'ip addr flush' to loop more than 10 times greearb
2010-06-29 6:12 ` David Miller [this message]
2010-06-29 6:27 ` Ben Greear
2010-06-29 6:36 ` David Miller
2010-06-29 9:58 ` Andreas Henriksson
2010-06-29 14:59 ` Ben Greear
2010-06-29 15:10 ` Ben Greear
2010-06-29 17:02 ` David Miller
2010-06-29 8:03 ` Alexander Clouter
2010-06-29 15:04 ` Ben Greear
2010-06-29 15:48 ` Alexander Clouter
2010-06-29 16:30 ` Ben Greear
2010-08-04 21:00 ` Stephen Hemminger
2010-08-04 21:13 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628.231204.229752207.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=greearb@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).