* [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed
@ 2010-06-23 18:35 Jiri Pirko
2010-06-23 18:46 ` Florian Westphal
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Pirko @ 2010-06-23 18:35 UTC (permalink / raw)
To: netdev; +Cc: davem, kaber
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
diff --git a/net/netfilter/nf_tproxy_core.c b/net/netfilter/nf_tproxy_core.c
index 5490fc3..ec6737c 100644
--- a/net/netfilter/nf_tproxy_core.c
+++ b/net/netfilter/nf_tproxy_core.c
@@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
return 0;
}
+static void __exit nf_tproxy_exit(void)
+{
+}
+
module_init(nf_tproxy_init);
+module_exit(nf_tproxy_exit);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Krisztian Kovacs");
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed
2010-06-23 18:35 [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed Jiri Pirko
@ 2010-06-23 18:46 ` Florian Westphal
2010-06-23 18:55 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Florian Westphal @ 2010-06-23 18:46 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, davem, kaber
Jiri Pirko <jpirko@redhat.com> wrote:
> diff --git a/net/netfilter/nf_tproxy_core.c b/net/netfilter/nf_tproxy_core.c
> index 5490fc3..ec6737c 100644
> --- a/net/netfilter/nf_tproxy_core.c
> +++ b/net/netfilter/nf_tproxy_core.c
> @@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
> return 0;
> }
>
> +static void __exit nf_tproxy_exit(void)
> +{
> +}
> +
> module_init(nf_tproxy_init);
> +module_exit(nf_tproxy_exit);
tproxy assigns skb->destructor, what prevents module unload while such skbs may
still be around?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed
2010-06-23 18:46 ` Florian Westphal
@ 2010-06-23 18:55 ` David Miller
2010-06-24 15:29 ` Patrick McHardy
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2010-06-23 18:55 UTC (permalink / raw)
To: fw; +Cc: jpirko, netdev, kaber
From: Florian Westphal <fw@strlen.de>
Date: Wed, 23 Jun 2010 20:46:11 +0200
> tproxy assigns skb->destructor, what prevents module unload while such skbs may
> still be around?
The only reference to nf_tproxy_core.ko is for the symbol, "nf_tproxy_assign_sock".
xt_TPROXY.c, which references this symbol, thus creates a symbol dependency on this
module, so xt_TPROXY.o needs to unload before nf_tproxy_core.ko can unload, and
xt_TPROXY.o has it's own manner for handling module references properly.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed
2010-06-23 18:55 ` David Miller
@ 2010-06-24 15:29 ` Patrick McHardy
2010-06-25 7:56 ` KOVACS Krisztian
2010-06-29 6:38 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Patrick McHardy @ 2010-06-24 15:29 UTC (permalink / raw)
To: David Miller; +Cc: fw, jpirko, netdev, Balazs Scheidler, KOVACS Krisztian
David Miller wrote:
> From: Florian Westphal <fw@strlen.de>
> Date: Wed, 23 Jun 2010 20:46:11 +0200
>
>
>> tproxy assigns skb->destructor, what prevents module unload while such skbs may
>> still be around?
>>
>
> The only reference to nf_tproxy_core.ko is for the symbol, "nf_tproxy_assign_sock".
> xt_TPROXY.c, which references this symbol, thus creates a symbol dependency on this
> module, so xt_TPROXY.o needs to unload before nf_tproxy_core.ko can unload, and
> xt_TPROXY.o has it's own manner for handling module references properly.
>
I don't see anything waiting for skbs in flight using the tproxy
destructor in either xt_TPROXY or nf_tproxy_core though, so I think
Florian is correct.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed
2010-06-24 15:29 ` Patrick McHardy
@ 2010-06-25 7:56 ` KOVACS Krisztian
2010-06-29 6:38 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: KOVACS Krisztian @ 2010-06-25 7:56 UTC (permalink / raw)
To: Patrick McHardy; +Cc: David Miller, fw, jpirko, netdev, Balazs Scheidler
Hi,
On 06/24/2010 05:29 PM, Patrick McHardy wrote:
> David Miller wrote:
>> From: Florian Westphal <fw@strlen.de>
>> Date: Wed, 23 Jun 2010 20:46:11 +0200
>>
>>> tproxy assigns skb->destructor, what prevents module unload while
>>> such skbs may
>>> still be around?
>>
>> The only reference to nf_tproxy_core.ko is for the symbol,
>> "nf_tproxy_assign_sock".
>> xt_TPROXY.c, which references this symbol, thus creates a symbol
>> dependency on this
>> module, so xt_TPROXY.o needs to unload before nf_tproxy_core.ko can
>> unload, and
>> xt_TPROXY.o has it's own manner for handling module references properly.
>
> I don't see anything waiting for skbs in flight using the tproxy
> destructor in either xt_TPROXY or nf_tproxy_core though, so I think
> Florian is correct.
Yes, I think Florian and Patrick's right. Right now there's nothing
preventing xt_TPROXY and nf_tproxy_core from being removed while there
are skbs in flight with the tproxy destructor set.
--
KOVACS Krisztian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed
2010-06-24 15:29 ` Patrick McHardy
2010-06-25 7:56 ` KOVACS Krisztian
@ 2010-06-29 6:38 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2010-06-29 6:38 UTC (permalink / raw)
To: kaber; +Cc: fw, jpirko, netdev, bazsi, hidden
From: Patrick McHardy <kaber@trash.net>
Date: Thu, 24 Jun 2010 17:29:29 +0200
> David Miller wrote:
>> From: Florian Westphal <fw@strlen.de>
>> Date: Wed, 23 Jun 2010 20:46:11 +0200
>>
>>
>>> tproxy assigns skb->destructor, what prevents module unload while such
>>> skbs may
>>> still be around?
>>>
>>
>> The only reference to nf_tproxy_core.ko is for the symbol,
>> "nf_tproxy_assign_sock".
>> xt_TPROXY.c, which references this symbol, thus creates a symbol
>> dependency on this
>> module, so xt_TPROXY.o needs to unload before nf_tproxy_core.ko can
>> unload, and
>> xt_TPROXY.o has it's own manner for handling module references
>> properly.
>>
>
> I don't see anything waiting for skbs in flight using the tproxy
> destructor in either xt_TPROXY or nf_tproxy_core though, so I think
> Florian is correct.
Ok.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-06-29 6:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-23 18:35 [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed Jiri Pirko
2010-06-23 18:46 ` Florian Westphal
2010-06-23 18:55 ` David Miller
2010-06-24 15:29 ` Patrick McHardy
2010-06-25 7:56 ` KOVACS Krisztian
2010-06-29 6:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).