From: David Miller <davem@davemloft.net>
To: andy@greyhouse.net
Cc: netdev@vger.kernel.org, amwang@redhat.com, fubar@us.ibm.com
Subject: Re: [PATCH 2.6.35] bonding: prevent netpoll over bonded interfaces
Date: Mon, 28 Jun 2010 23:54:44 -0700 (PDT) [thread overview]
Message-ID: <20100628.235444.241924787.davem@davemloft.net> (raw)
In-Reply-To: <20100625195044.GQ7497@gospo.rdu.redhat.com>
From: Andy Gospodarek <andy@greyhouse.net>
Date: Fri, 25 Jun 2010 15:50:44 -0400
>
> Support for netpoll over bonded interfaces was added here:
>
> commit f6dc31a85cd46a959bdd987adad14c3b645e03c1
> Author: WANG Cong <amwang@redhat.com>
> Date: Thu May 6 00:48:51 2010 -0700
>
> bonding: make bonding support netpoll
>
> but it is bad enough that we should probably just disable netpoll over
> bonding until some of the locking logic in the bonding driver is changed
> or converted completely to RCU. Simple actions like changing the active
> slave in active-backup mode will hang the box if a high enough printk
> debugging level is enabled.
>
> Keeping the old code around will be good for anyone that wants to work
> on it (and for after the RCU conversion), so I propose this small patch
> rather than ripping it all out.
>
> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Applied, thanks a lot Andy.
prev parent reply other threads:[~2010-06-29 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 19:50 [PATCH 2.6.35] bonding: prevent netpoll over bonded interfaces Andy Gospodarek
2010-06-25 22:31 ` Andi Kleen
2010-06-25 22:52 ` Jay Vosburgh
2010-06-29 6:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628.235444.241924787.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).