From: Stanislaw Gruszka <sgruszka@redhat.com>
To: netdev@vger.kernel.org
Cc: Amerigo Wang <amwang@redhat.com>,
Amit Kumar Salecha <amit.salecha@qlogic.com>,
Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Subject: [PATCH -next] qlcnic: fail when try to setup unsupported features
Date: Mon, 28 Jun 2010 11:31:34 +0200 [thread overview]
Message-ID: <20100628113134.0c5208b0@dhcp-lab-109.englab.brq.redhat.com> (raw)
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/qlcnic/qlcnic_ethtool.c | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qlcnic/qlcnic_ethtool.c b/drivers/net/qlcnic/qlcnic_ethtool.c
index d4e803e..b9d5acb 100644
--- a/drivers/net/qlcnic/qlcnic_ethtool.c
+++ b/drivers/net/qlcnic/qlcnic_ethtool.c
@@ -983,12 +983,19 @@ static int qlcnic_set_flags(struct net_device *netdev, u32 data)
struct qlcnic_adapter *adapter = netdev_priv(netdev);
int hw_lro;
+ if (data & ~ETH_FLAG_LRO)
+ return -EOPNOTSUPP;
+
if (!(adapter->capabilities & QLCNIC_FW_CAPABILITY_HW_LRO))
return -EINVAL;
- ethtool_op_set_flags(netdev, data);
-
- hw_lro = (data & ETH_FLAG_LRO) ? QLCNIC_LRO_ENABLED : 0;
+ if (data & ETH_FLAG_LRO) {
+ hw_lro = QLCNIC_LRO_ENABLED;
+ netdev->features |= NETIF_F_LRO;
+ } else {
+ hw_lro = 0;
+ netdev->features &= ~NETIF_F_LRO;
+ }
if (qlcnic_config_hw_lro(adapter, hw_lro))
return -EIO;
--
1.5.5.6
next reply other threads:[~2010-06-28 9:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 9:31 Stanislaw Gruszka [this message]
2010-06-28 12:36 ` [PATCH -next] qlcnic: fail when try to setup unsupported features Amit Salecha
2010-06-28 12:58 ` Stanislaw Gruszka
2010-06-28 13:09 ` Amit Salecha
2010-06-28 14:14 ` Stanislaw Gruszka
2010-06-28 14:18 ` Ben Hutchings
2010-06-29 14:41 ` Ben Hutchings
2010-06-29 15:00 ` Stanislaw Gruszka
2010-06-29 15:05 ` Ben Hutchings
2010-06-29 16:01 ` [RFC] [PATCH] ethtool: Change ethtool_op_set_flags to validate flags Ben Hutchings
2010-06-30 5:26 ` Jeff Garzik
2010-06-30 11:21 ` Stanislaw Gruszka
2010-06-30 20:47 ` David Miller
2010-06-29 16:59 ` [PATCH -next] qlcnic: fail when try to setup unsupported features David Miller
2010-06-28 13:16 ` Ben Hutchings
2010-06-28 13:30 ` Ben Hutchings
2010-06-28 14:18 ` Stanislaw Gruszka
2010-06-29 7:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628113134.0c5208b0@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=amit.salecha@qlogic.com \
--cc=amwang@redhat.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).