From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Amit Salecha <amit.salecha@qlogic.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Amerigo Wang <amwang@redhat.com>,
Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Subject: Re: [PATCH -next] qlcnic: fail when try to setup unsupported features
Date: Mon, 28 Jun 2010 16:18:23 +0200 [thread overview]
Message-ID: <20100628161823.623343d5@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <1277731840.2089.8.camel@achroite.uk.solarflarecom.com>
On Mon, 28 Jun 2010 14:30:40 +0100
Ben Hutchings <bhutchings@solarflare.com> wrote:
> > It would be more useful to add a supported_flags parameter to
> > ethtool_op_set_flags() so it can check the requested flags against the
> > driver/hardware capabilities.
>
> I also just noticed that ethtool.h says set_flags() will return -EINVAL
> for unsupported values. The current implementations variously return
> -EINVAL or -EOPNOTSUPP.
We need to unify ... , I prefer EOPNOTSUPP since this is returned now
if .set_flags == NULL. That will require to change a comment in
ethtool.h and some drivers, I will take a look at it.
Stanislaw
next prev parent reply other threads:[~2010-06-28 14:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 9:31 [PATCH -next] qlcnic: fail when try to setup unsupported features Stanislaw Gruszka
2010-06-28 12:36 ` Amit Salecha
2010-06-28 12:58 ` Stanislaw Gruszka
2010-06-28 13:09 ` Amit Salecha
2010-06-28 14:14 ` Stanislaw Gruszka
2010-06-28 14:18 ` Ben Hutchings
2010-06-29 14:41 ` Ben Hutchings
2010-06-29 15:00 ` Stanislaw Gruszka
2010-06-29 15:05 ` Ben Hutchings
2010-06-29 16:01 ` [RFC] [PATCH] ethtool: Change ethtool_op_set_flags to validate flags Ben Hutchings
2010-06-30 5:26 ` Jeff Garzik
2010-06-30 11:21 ` Stanislaw Gruszka
2010-06-30 20:47 ` David Miller
2010-06-29 16:59 ` [PATCH -next] qlcnic: fail when try to setup unsupported features David Miller
2010-06-28 13:16 ` Ben Hutchings
2010-06-28 13:30 ` Ben Hutchings
2010-06-28 14:18 ` Stanislaw Gruszka [this message]
2010-06-29 7:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628161823.623343d5@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=amit.salecha@qlogic.com \
--cc=amwang@redhat.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).