netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: sjurbr@gmail.com, netdev@vger.kernel.org, marcel@holtmann.org,
	daniel.martensson@stericsson.com, linus.walleij@stericsson.com
Subject: Re: [PATCH v4 2/2] caif-driver: Add CAIF-SPI Protocol driver.
Date: Tue, 29 Jun 2010 00:10:20 -0700 (PDT)	[thread overview]
Message-ID: <20100629.001020.58427550.davem@davemloft.net> (raw)
In-Reply-To: <1277587889-17314-2-git-send-email-sjur.brandeland@stericsson.com>

From: sjur.brandeland@stericsson.com
Date: Sat, 26 Jun 2010 23:31:29 +0200

> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
> 
> This patch introduces the CAIF SPI Protocol Driver for
> CAIF Link Layer.
> 
> This driver implements a platform driver to accommodate for a
> platform specific SPI device. A general platform driver is not
> possible as there are no SPI Slave side Kernel API defined.
> A sample CAIF SPI Platform device can be found in
> .../Documentation/networking/caif/spi_porting.txt
> 
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>

Applied, but:

> +
> +config CAIF_SPI_SYNC
> +	bool "Next command and length in start of frame"
> +	depends on CAIF_SPI_SLAVE
> +	default n
> +	---help---
> +	Putting the next command and length in the start of the frame can
> +	help to synchronize to the next transfer in case of over or under-runs.
> +	This option also needs to be enabled on the modem.
> +

This adds an extra new-line at the end of the file, which I corrected
when applying this.

GIT warns when trying to apply a patch with this problem,
checkpatch.pl probably does too, so you really can (in an automated
way) prevent these things from showing up in your submission.

  reply	other threads:[~2010-06-29  7:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21 21:58 [PATCH v2] caif-driver: Add CAIF-SPI Protocol driver sjur.brandeland
2010-06-26  4:12 ` David Miller
2010-06-26 21:31   ` [PATCH 1/2] caif: Kconfig and Makefile fixes sjur.brandeland
2010-06-26 21:31     ` [PATCH v4 2/2] caif-driver: Add CAIF-SPI Protocol driver sjur.brandeland
2010-06-29  7:10       ` David Miller [this message]
2010-06-29  7:08     ` [PATCH 1/2] caif: Kconfig and Makefile fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100629.001020.58427550.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=daniel.martensson@stericsson.com \
    --cc=linus.walleij@stericsson.com \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=sjur.brandeland@stericsson.com \
    --cc=sjurbr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).