* [PATCH -next] netxen: fail when try to setup unsupported features
@ 2010-06-28 9:33 Stanislaw Gruszka
2010-06-29 7:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stanislaw Gruszka @ 2010-06-28 9:33 UTC (permalink / raw)
To: netdev; +Cc: Amerigo Wang, Amit Kumar Salecha
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/netxen/netxen_nic_ethtool.c | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/netxen/netxen_nic_ethtool.c b/drivers/net/netxen/netxen_nic_ethtool.c
index 20f7c58..6d94ee5 100644
--- a/drivers/net/netxen/netxen_nic_ethtool.c
+++ b/drivers/net/netxen/netxen_nic_ethtool.c
@@ -887,12 +887,19 @@ static int netxen_nic_set_flags(struct net_device *netdev, u32 data)
struct netxen_adapter *adapter = netdev_priv(netdev);
int hw_lro;
+ if (data & ~ETH_FLAG_LRO)
+ return -EOPNOTSUPP;
+
if (!(adapter->capabilities & NX_FW_CAPABILITY_HW_LRO))
return -EINVAL;
- ethtool_op_set_flags(netdev, data);
-
- hw_lro = (data & ETH_FLAG_LRO) ? NETXEN_NIC_LRO_ENABLED : 0;
+ if (data & ETH_FLAG_LRO) {
+ hw_lro = NETXEN_NIC_LRO_ENABLED;
+ netdev->features |= NETIF_F_LRO;
+ } else {
+ hw_lro = 0;
+ netdev->features &= ~NETIF_F_LRO;
+ }
if (netxen_config_hw_lro(adapter, hw_lro))
return -EIO;
--
1.5.5.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-29 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-28 9:33 [PATCH -next] netxen: fail when try to setup unsupported features Stanislaw Gruszka
2010-06-29 7:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).