From: Simon Horman <horms@verge.net.au>
To: Casey Leedom <leedom@chelsio.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 4/9] cxgb4vf: Add code to provision T4 PCI-E SR-IOV Virtual Functions with hardware resources
Date: Tue, 29 Jun 2010 09:51:29 +0900 [thread overview]
Message-ID: <20100629005129.GK10073@verge.net.au> (raw)
In-Reply-To: <201006280955.07352.leedom@chelsio.com>
On Mon, Jun 28, 2010 at 09:55:07AM -0700, Casey Leedom wrote:
> | From: Simon Horman <horms@verge.net.au>
> | Date: Saturday, June 26, 2010 06:37 am
> |
> | I wonder if it would be cleaner to move the guts of the last hunk
> | into a function (e.g. adap_init_sriov()) and have that be a dummy
> | function in the case that CONFIG_PCI_IOV in the first hunk is not set.
>
> I have no objection to this. I'd like to do minor tuning work like
> that as a follow on rather than respin the patch. But, as I said in my
> submission, I'm not familiar with this process so if making changes like
> the above is required I'll definitely jump on it. I don't know what
> issues are "critical show stoppers" and which ones are "nice to have"
> once things are in place.
I don't regard my suggestion as merge-critical.
prev parent reply other threads:[~2010-06-29 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 22:11 [PATCH 4/9] cxgb4vf: Add code to provision T4 PCI-E SR-IOV Virtual Functions with hardware resources Casey Leedom
2010-06-26 13:37 ` Simon Horman
2010-06-28 16:55 ` Casey Leedom
2010-06-29 0:51 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629005129.GK10073@verge.net.au \
--to=horms@verge.net.au \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).