From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: ben@decadent.org.uk, netdev@vger.kernel.org,
chase.douglas@canonical.com, nordmark@mech.kth.se
Subject: Re: [PATCH net-next-2.6 2/2] 3c59x: Use fine-grained locks for MII and windowed register access
Date: Tue, 29 Jun 2010 08:39:32 +0200 [thread overview]
Message-ID: <20100629063932.GA10072@secunet.com> (raw)
In-Reply-To: <20100628.231812.35040625.davem@davemloft.net>
On Mon, Jun 28, 2010 at 11:18:12PM -0700, David Miller wrote:
>
> Once Ben posts a new version of this second patch with the
> proper spin_lock_init() calls added I am going to apply both
> of his changes.
Yes, of course apply them. It was just a recommendation to avoid the locks
in the cases they are not needed. These patches are a real improvement,
so I'm fine with them.
Steffen
next prev parent reply other threads:[~2010-06-29 6:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 23:52 [PATCH net-next-2.6 0/2] 3c59x: Locking fixes Ben Hutchings
2010-06-23 23:54 ` [PATCH net-next-2.6 1/2] 3c59x: Specify window explicitly for access to windowed registers Ben Hutchings
2010-06-29 6:20 ` David Miller
2010-06-23 23:55 ` [PATCH net-next-2.6 2/2] 3c59x: Use fine-grained locks for MII and windowed register access Ben Hutchings
2010-06-24 12:05 ` Steffen Klassert
2010-06-24 12:57 ` Ben Hutchings
2010-06-24 14:00 ` Steffen Klassert
2010-06-25 0:45 ` Ben Hutchings
2010-06-25 8:24 ` Steffen Klassert
2010-06-29 6:18 ` David Miller
2010-06-29 6:39 ` Steffen Klassert [this message]
2010-06-30 1:26 ` [PATCHv2 net-next-2.6] " Ben Hutchings
2010-06-30 6:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629063932.GA10072@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=ben@decadent.org.uk \
--cc=chase.douglas@canonical.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nordmark@mech.kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).