From: Stanislaw Gruszka <sgruszka@redhat.com>
To: netdev@vger.kernel.org
Cc: Amerigo Wang <amwang@redhat.com>,
Andrew Gallatin <gallatin@myri.com>,
Brice Goglin <brice@myri.com>
Subject: [PATCH -next] myri10ge: clear NETIF_F_LRO bit directly
Date: Tue, 29 Jun 2010 16:37:31 +0200 [thread overview]
Message-ID: <20100629163731.1d174b07@dhcp-lab-109.englab.brq.redhat.com> (raw)
Do not use ethtool_op_set_flags() to clear one bit in ->features.
Inform user about disabling LRO.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/myri10ge/myri10ge.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index e0b47cc..2259168 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -1725,17 +1725,15 @@ static u32 myri10ge_get_rx_csum(struct net_device *netdev)
static int myri10ge_set_rx_csum(struct net_device *netdev, u32 csum_enabled)
{
struct myri10ge_priv *mgp = netdev_priv(netdev);
- int err = 0;
if (csum_enabled)
mgp->csum_flag = MXGEFW_FLAGS_CKSUM;
else {
- u32 flags = ethtool_op_get_flags(netdev);
- err = ethtool_op_set_flags(netdev, (flags & ~ETH_FLAG_LRO));
mgp->csum_flag = 0;
-
+ netdev->features &= ~NETIF_F_LRO;
+ netdev_info(netdev, "RX checksumming set off, disabling LRO\n");
}
- return err;
+ return 0;
}
static int myri10ge_set_tso(struct net_device *netdev, u32 tso_enabled)
--
1.5.5.6
next reply other threads:[~2010-06-29 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 14:37 Stanislaw Gruszka [this message]
2010-06-29 15:44 ` [PATCH -next] myri10ge: clear NETIF_F_LRO bit directly Andrew Gallatin
2010-06-30 11:26 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629163731.1d174b07@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=amwang@redhat.com \
--cc=brice@myri.com \
--cc=gallatin@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).