* [PATCH -next] ixgbe: use NETIF_F_LRO
@ 2010-06-29 14:38 Stanislaw Gruszka
2010-06-29 18:00 ` Jeff Kirsher
0 siblings, 1 reply; 2+ messages in thread
From: Stanislaw Gruszka @ 2010-06-29 14:38 UTC (permalink / raw)
To: netdev; +Cc: Jeff Kirsher
Both ETH_FLAG_LRO and NETIF_F_LRO have the same value, but NETIF_F_LRO
is intended to use with netdev->features.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/ixgbe/ixgbe_ethtool.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c
index 873b45e..e2ab4ae 100644
--- a/drivers/net/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ixgbe/ixgbe_ethtool.c
@@ -2227,7 +2227,7 @@ static int ixgbe_set_flags(struct net_device *netdev, u32 data)
break;
}
} else if (!adapter->rx_itr_setting) {
- netdev->features &= ~ETH_FLAG_LRO;
+ netdev->features &= ~NETIF_F_LRO;
if (data & ETH_FLAG_LRO)
e_info("rx-usecs set to 0, "
"LRO/RSC cannot be enabled.\n");
--
1.5.5.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] ixgbe: use NETIF_F_LRO
2010-06-29 14:38 [PATCH -next] ixgbe: use NETIF_F_LRO Stanislaw Gruszka
@ 2010-06-29 18:00 ` Jeff Kirsher
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Kirsher @ 2010-06-29 18:00 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: netdev
On Tue, Jun 29, 2010 at 07:38, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Both ETH_FLAG_LRO and NETIF_F_LRO have the same value, but NETIF_F_LRO
> is intended to use with netdev->features.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
> drivers/net/ixgbe/ixgbe_ethtool.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c
> index 873b45e..e2ab4ae 100644
> --- a/drivers/net/ixgbe/ixgbe_ethtool.c
> +++ b/drivers/net/ixgbe/ixgbe_ethtool.c
> @@ -2227,7 +2227,7 @@ static int ixgbe_set_flags(struct net_device *netdev, u32 data)
> break;
> }
> } else if (!adapter->rx_itr_setting) {
> - netdev->features &= ~ETH_FLAG_LRO;
> + netdev->features &= ~NETIF_F_LRO;
> if (data & ETH_FLAG_LRO)
> e_info("rx-usecs set to 0, "
> "LRO/RSC cannot be enabled.\n");
> --
Thanks, I have added it to my queue of patches.
--
Cheers,
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-29 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-29 14:38 [PATCH -next] ixgbe: use NETIF_F_LRO Stanislaw Gruszka
2010-06-29 18:00 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).