From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: hadi@cyberus.ca, xiaosuo@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] act_nat: use stack variable
Date: Wed, 30 Jun 2010 12:12:52 -0700 (PDT) [thread overview]
Message-ID: <20100630.121252.228948995.davem@davemloft.net> (raw)
In-Reply-To: <20100630103005.GA24688@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 30 Jun 2010 18:30:05 +0800
> On Wed, Jun 30, 2010 at 06:25:21AM -0400, jamal wrote:
>> On Wed, 2010-06-30 at 17:07 +0800, Changli Gao wrote:
>> > act_nat: use stack variable
>> >
>> > structure tc_nat isn't too big for stack, so we can put it in stack.
>> >
>> > Signed-off-by: Changli Gao <xiaosuo@gmail.com>
>>
>> Doesnt look unreasonable - will let Herbert make the call..
>
> Looks good to me too.
Applied.
prev parent reply other threads:[~2010-06-30 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 9:07 [PATCH] act_nat: use stack variable Changli Gao
2010-06-30 10:25 ` jamal
2010-06-30 10:30 ` Herbert Xu
2010-06-30 19:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630.121252.228948995.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).