From: David Miller <davem@davemloft.net>
To: james.dutton@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Fix b44 RX FIFO overflow recovery.
Date: Wed, 30 Jun 2010 13:25:53 -0700 (PDT) [thread overview]
Message-ID: <20100630.132553.163237479.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTik2BadzkkVcmlhgWh6rcLDm1kEu0RDqWuILnwVZ@mail.gmail.com>
From: James Courtier-Dutton <james.dutton@gmail.com>
Date: Wed, 30 Jun 2010 21:11:18 +0100
> diff --git a/drivers/net/b44.c b/drivers/net/b44.c
> index 69d9f3d..72537c1 100644
> --- a/drivers/net/b44.c
> +++ b/drivers/net/b44.c
> @@ -852,12 +852,46 @@ static int b44_poll(struct napi_struct *napi, int budget)
> /* spin_unlock(&bp->tx_lock); */
> }
> spin_unlock_irqrestore(&bp->lock, flags);
> + if (bp->istat & ISTAT_DSCE)
> + {
> + printk(KERN_INFO "b44_poll: ISTAT_DSCE\n");
> + }
Using braces here is overkill, and even if it was appropriate it's formatted
incorrectly, it should be:
if (x)
y;
for single-line code blocks, and:
if (x) {
y;
z;
}
For multi-line code blocks.
prev parent reply other threads:[~2010-06-30 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 20:11 [PATCH] Fix b44 RX FIFO overflow recovery James Courtier-Dutton
2010-06-30 20:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630.132553.163237479.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=james.dutton@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).