From: David Miller <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] snmp: 64bit ipstats_mib for all arches
Date: Wed, 30 Jun 2010 13:30:34 -0700 (PDT) [thread overview]
Message-ID: <20100630.133034.139124730.davem@davemloft.net> (raw)
In-Reply-To: <4C2A0C22.4010202@linux-ipv6.org>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Wed, 30 Jun 2010 00:07:14 +0900
> Hello.
>
> Thank you for doing this work!
>
> Eric Dumazet wrote:
>> /proc/net/snmp and /proc/net/netstat expose SNMP counters.
>> Width of these counters is either 32 or 64 bits, depending on the size
>> of "unsigned long" in kernel.
>> This means user program parsing these files must already be prepared
>> to
>> deal with 64bit values, regardless of user program being 32 or 64 bit.
>
> Well, I'm rather not in favor of breaking user-space apps.
Eric has explained that applications must already be able to cope with
64-bit values here. I think this is a valid change to make and
telling users that non-broken (read as: 64-bit) stats are only
available via netlink is not a reasonable thing at all.
I'm going to apply Eric's patch.
prev parent reply other threads:[~2010-06-30 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 16:47 [RFC net-next-2.6] snmp: ipstats_mib becomes u64 for all arches Eric Dumazet
2010-06-29 13:48 ` [PATCH net-next-2.6] snmp: 64bit ipstats_mib " Eric Dumazet
2010-06-29 15:07 ` YOSHIFUJI Hideaki
2010-06-30 20:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630.133034.139124730.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).