From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RFC] [PATCH] ethtool: Change ethtool_op_set_flags to validate flags Date: Wed, 30 Jun 2010 13:47:41 -0700 (PDT) Message-ID: <20100630.134741.37566671.davem@davemloft.net> References: <1277823923.2112.26.camel@achroite.uk.solarflarecom.com> <1277827261.2112.48.camel@achroite.uk.solarflarecom.com> <20100630132111.72559f9f@dhcp-lab-109.englab.brq.redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: bhutchings@solarflare.com, amit.salecha@qlogic.com, netdev@vger.kernel.org, amwang@redhat.com, anirban.chakraborty@qlogic.com To: sgruszka@redhat.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:35535 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752867Ab0F3Ur2 (ORCPT ); Wed, 30 Jun 2010 16:47:28 -0400 In-Reply-To: <20100630132111.72559f9f@dhcp-lab-109.englab.brq.redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Stanislaw Gruszka Date: Wed, 30 Jun 2010 13:21:11 +0200 > On Tue, 29 Jun 2010 17:01:01 +0100 > Ben Hutchings wrote: > >> This is the sort of change I'd like to see. ... > Looks good for me as well. > > Reviewed-by: Stanislaw Gruszka Me too. Ben, please submit this formally.